lightningd: fix rpc_command hook #7773
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When trying to subscribe renepay to an rpc_command hook I noticed the initialization of the plugins will time out. It seems that at initialization we have a recursive hook call that keeps lightningd hooked to synchronous communication with the subscriber. By letting hooks apply on after plugin startup the problem is fixed. Changelog-Fixed: lightningd: fixes rpc_command hooks causing a infinite io loop at plugin initialization Signed-off-by: Lagrang3 <[email protected]>
vincenzopalazzo
approved these changes
Oct 31, 2024
Collaborator
vincenzopalazzo
left a comment
vincenzopalazzo
left a comment
There was a problem hiding this comment.
YAY
ACK 49e7dcd
Contributor
|
I have a more general fix, though this isn't bad in itself. This won't work for plugins which are started after initialization, however. See #7750 |
Collaborator
Author
|
I am closing this since the new libplugin interface passes a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When trying to subscribe renepay to an rpc_command hook I noticed the initialization of the plugins will time out.
It seems that at initialization we have a recursive hook call that keeps lightningd hooked to synchronous communication with the subscriber. By letting hooks apply only after plugin startup the problem is fixed.
Changelog-Fixed: lightningd: fixes rpc_command hooks causing a infinite io loop at plugin initialization