Skip to content

Small xpay improvements. #8516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Small xpay improvements. #8516

wants to merge 6 commits into from
+259 −48

Conversation

rustyrussell
Copy link
Contributor

@rustyrussell rustyrussell commented Aug 29, 2025 •
edited
Loading

  1. Don't fetchinvoice if we're running the check command.
  2. Test (successfully!) that we fill in the BIP353 fields in the invoice request.
  3. Provide helpful notifications to the caller as we resolve the BIP353 and fetchinvoice.
  4. Allow setting "payer_note" to spam offers.
  5. Forward notifications from askrene's getroutes to callers of xpay.

Closes: #8515

@rustyrussell rustyrussell added this to the v25.12 milestone Aug 29, 2025
@Lagrang3 Lagrang3 self-assigned this Aug 29, 2025
Lagrang3
Lagrang3 approved these changes Aug 29, 2025
View reviewed changes
Copy link
Collaborator

@Lagrang3 Lagrang3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty straightforward.

@rustyrussell
xpay: provide notifications while fetching BIP353 and doing fetchinvo…
52822d6 
…ice.

Otherwise cmdline just sees a long pause.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `xpay` fills the awkward silence with notifications when fetching BIP353 or invoices for offers.
@rustyrussell
xpay: allow setting payer_note for spamming when paying BIP353 or raw…
fff7dca 
… offers.

Simply forwards this to the fetchinvoice call.

Signed-off-by: Rusty Russell <[email protected]>
Changelog-Added: JSON-RPC: `xpay` supports `payer_note` to embed a note in the invoice when paying BIP353 or offers.
@rustyrussell
libplugin: add callback for command notifications.
4524888 
Signed-off-by: Rusty Russell <[email protected]>
@rustyrussell
xpay: forward command notifications from askrene.
99fb900 
This gives us more route details (particularly at higher log levels).

Signed-off-by: Rusty Russell <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lagrang3 Lagrang3 Lagrang3 approved these changes

@cdecker cdecker Awaiting requested review from cdecker cdecker is a code owner

Assignees

@Lagrang3 Lagrang3

Labels
None yet
Projects
None yet
Milestone
v25.12
Development

Successfully merging this pull request may close these issues.

xpay should provide notifications when paying BIP353
2 participants
@rustyrussell @Lagrang3