Skip to content

Conversation

king-11
Copy link
Contributor

@king-11 king-11 commented Aug 31, 2025

Important

25.09 FREEZE July 28TH: Non-bugfix PRs not ready by this date will wait for 25.12.

RC1 is scheduled on August 11th

The final release is scheduled for September 1st.

we can get rid of __init__.py files at namespace package level as its only required to support python 2 and beyond python 3.3+ we would be good.

we had also declared the package sources twice which are already declared at workspace root level. so removing the duplicate source entries.

Checklist

Before submitting the PR, ensure the following tasks are completed. If an item is not applicable to your PR, please mark it as checked:

  • The changelog has been updated in the relevant commit(s) according to the guidelines.
  • Tests have been added or modified to reflect the changes.
  • Documentation has been reviewed and updated as needed.
  • Related issues have been listed and linked, including any that this PR closes.

for python 3.3+ we don’t need an __init__.py at namespace package to 
allow extensions instead we can just get rid of them
duplicate definition isn’t required as we already defined them at 
workspace level sources
@king-11 king-11 requested a review from cdecker as a code owner August 31, 2025 14:26
@daywalker90
Copy link
Collaborator

What about adding --frozen to the installation documentation? At least for production, as uv automatically syncs on almost every command and therefore could update uv.lock and leave a dirty git tree resulting in a -modded CLN version.

@madelinevibes madelinevibes added this to the v25.12 milestone Sep 1, 2025
@king-11
Copy link
Contributor Author

king-11 commented Sep 1, 2025

What about adding --frozen to the installation documentation? At least for production, as uv automatically syncs on almost every command and therefore could update uv.lock and leave a dirty git tree resulting in a -modded CLN version.

Makes sense will update the docs for the same as well

@madelinevibes madelinevibes added the Type::Bug An error, flaw, or fault that produces an incorrect or unexpected result label Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type::Bug An error, flaw, or fault that produces an incorrect or unexpected result
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants