ci: Add a new step to update pyln versions out of WORKDIR #8529
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShahanaFarooqui
requested review from
sangbida
and removed request for
madelinevibes
|
This is great, BUT: This NEEDS to go in the commit message. Everything in GitHub will vanish and be lost, only the git commit contents will remain. And I will not be able to tell why this change was made from the commit message: ? |
rustyrussell
requested changes
Sep 4, 2025
ShahanaFarooqui
force-pushed
the
fix-pypi-update-versions
branch
from
f953d32 to
79d6646
Compare
The Publish distribution stage was failing because it executed the update-pyln-versions script from within the WORKDIR, which created an invalid context. To resolve this, we have decoupled the process, separating the updating of version state into its own step that runs from the root directory before the publish operation. Changelog-None.
ShahanaFarooqui
force-pushed
the
fix-pypi-update-versions
branch
from
79d6646 to
7b65df3
Compare
|
I added the description in the commit but |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Publish distribution stage was failing because it executed the update-pyln-versions script from within the WORKDIR, which created an invalid context. To resolve this, we have decoupled the process, separating the updating of version state into its own step that runs from the root directory before the publish operation.
Changelog-None.