Remove external lowdown and libsodium in favor of builtins, remove litecoin (lol!) #8536
+21
−140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On GitHub where we build the zipfile, it exists, so we don't check out the submodule. If you do, your zipfile won't match! Signed-off-by: Rusty Russell <[email protected]>
…ic PR merged. Signed-off-by: Rusty Russell <[email protected]> Changelog-Fixed: Build: release builds with tools/build-release.sh are deterministic again.
Every distribution we have packages this now. Changelog-Changed: Build: lowdown is now required (we no longer bundle our own). Signed-off-by: Rusty Russell <[email protected]>
We shipped our own because Ubuntu xenial (16.4) had an ancient one. Changelog-Changed: Build: libsodium version >= 1.0.4 now required (released 2015-06-11) Signed-off-by: Rusty Russell <[email protected]>
No idea if it works, we don't test it and nobody runs it. I guess not. Signed-off-by: Rusty Russell <[email protected]> Changelog-Removed: Config: non-functioning litecoin support (who knew we even had that?)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #8530
Everyone packages lowdown and libsodium nowdays, and litecoin was never used.