Skip to content

lightningd: fix segfault when parse_filter fails #8780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
dovgopoly wants to merge 1 commit into
base: master
Choose a base branch
from
+7 −6
Open

lightningd: fix segfault when parse_filter fails #8780

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 7 additions & 6 deletions lightningd/jsonrpc.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1070,6 +1070,13 @@ parse_request(struct json_connection *jcon,
"Expected string for method");
}

c->json_cmd = find_cmd(jcon->ld->jsonrpc, buffer, method);
if (!c->json_cmd) {
return command_fail(
c, JSONRPC2_METHOD_NOT_FOUND, "Unknown command '%.*s'",
method->end - method->start, buffer + method->start);
}

if (filter) {
struct command_result *ret;
ret = parse_filter(c, "filter", buffer, filter);
Expand All @@ -1081,12 +1088,6 @@ parse_request(struct json_connection *jcon,
* actually just logging the id */
log_io(jcon->log, LOG_IO_IN, NULL, c->id, NULL, 0);

c->json_cmd = find_cmd(jcon->ld->jsonrpc, buffer, method);
if (!c->json_cmd) {
return command_fail(
c, JSONRPC2_METHOD_NOT_FOUND, "Unknown command '%.*s'",
method->end - method->start, buffer + method->start);
}
if (!command_deprecated_in_ok(c, NULL,
c->json_cmd->depr_start,
c->json_cmd->depr_end)) {
Expand Down
Loading