Skip to content

doc: document the direction field in listpeerchannels. #8781

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rustyrussell wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −7
Open

doc: document the direction field in listpeerchannels. #8781

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cln-grpc/proto/node.proto
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cln-grpc/src/convert.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion cln-rpc/src/model.rs
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 6 additions & 0 deletions contrib/msggen/msggen/schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24159,6 +24159,12 @@
"The short_channel_id (once locked in)."
]
},
"direction": {
"type": "integer",
"description": [
"The direction of the channel (i.e. 0 if we are the lesser node id, 1 if we are the greater)."
]
},
"channel_id": {
"type": "hash",
"description": [
Expand Down
2 changes: 1 addition & 1 deletion contrib/pyln-grpc-proto/pyln/grpc/node_pb2.py
View file
Open in desktop

Large diffs are not rendered by default.

6 changes: 6 additions & 0 deletions doc/schemas/listpeerchannels.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -311,6 +311,12 @@
"The short_channel_id (once locked in)."
]
},
"direction": {
"type": "integer",
"description": [
"The direction of the channel (i.e. 0 if we are the lesser node id, 1 if we are the greater)."
]
},
"channel_id": {
"type": "hash",
"description": [
Expand Down
6 changes: 3 additions & 3 deletions tests/test_plugin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3613,6 +3613,8 @@ def test_sql(node_factory, bitcoind):
'type': 'string'},
{'name': 'short_channel_id',
'type': 'short_channel_id'},
{'name': 'direction',
'type': 'u32'},
{'name': 'channel_id',
'type': 'hash'},
{'name': 'funding_txid',
Expand Down Expand Up @@ -3715,9 +3717,7 @@ def test_sql(node_factory, bitcoind):
{'name': 'close_to_addr',
'type': 'string'},
{'name': 'last_tx_fee_msat',
'type': 'msat'},
{'name': 'direction',
'type': 'u32'}]},
'type': 'msat'}]},
'peerchannels_features': {
'columns': [{'name': 'row',
'type': 'u64'},
Expand Down
Loading