multi: acceptdiscountctIsEnabled check in setup#348
Merged
Conversation
acceptdiscountctIsEnabled checks if the acceptdiscountct feature is enabled by decoding a hardcoded example transaction and checking for the presence of the DiscountVirtualSize field in the decoded transaction.
YusukeShimizu
force-pushed
the
acceptdiscountctIsEnabled
branch
from
9ef8cea to
bbfe93e
Compare
Collaborator
|
Tested ACK bbfe93e |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the process of launching peerswap, when elementsd is used, a check for
acceptdiscountctIsEnabledis added.The
acceptdiscountctIsEnabledchecks whether the acceptdiscountct feature is enabled by decoding a hard-coded transaction example and verifying if the decoded transaction contains the DiscountVirtualSize field.Depends on ElementsProject/glightning#22