[BR1230][T25029][ADD]project_timesheet_detail#212
Open
lonelysun wants to merge 4 commits intoElico-Corp:10.0from
Open
[BR1230][T25029][ADD]project_timesheet_detail#212lonelysun wants to merge 4 commits intoElico-Corp:10.0from
lonelysun wants to merge 4 commits intoElico-Corp:10.0from
Conversation
elicoidal
requested changes
Mar 21, 2018
Contributor
There was a problem hiding this comment.
by every single record -> one by one
|
|
||
| This module extends the function of project timesheet,allows the manager to | ||
| review, approve or reject the timesheet by every single record. | ||
|
|
| =========== | ||
|
|
||
| Bugs are tracked on `GitHub Issues | ||
| <https://github.com/Elico-Corp/elico_odoo/issues>`_. In case of trouble, please |
| { | ||
| 'name': "project_timesheet_detailed", | ||
| 'summary': """This module extends the function of project timesheet, | ||
| allows the manager to review, approve or reject the timesheet by every |
Contributor
There was a problem hiding this comment.
remove 'Sorry,' (everywhere)
| @api.constrains('task_id', 'issue_id') | ||
| def _check_task_and_issue(self): | ||
| if self.task_id and self.issue_id: | ||
| raise ValueError( |
| @@ -0,0 +1,127 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <odoo> | |||
Contributor
There was a problem hiding this comment.
Improve the xml format for readibility
| @@ -0,0 +1,59 @@ | |||
| <?xml version="1.0" encoding="utf-8"?> | |||
| <odoo> | |||
| <record id="view_project_check_tms" model="ir.ui.view"> | |||
Contributor
There was a problem hiding this comment.
Improve XML format for readibility
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
replace #207