Skip to content

[12.0][[BR001548]][MIG] timesheet_activity_report :Migration to 12.0#238

Open
Reinhard-sheng wants to merge 4 commits intoElico-Corp:12.0from
Reinhard-sheng:12.0-mig-timesheet_activity_report
Open

[12.0][[BR001548]][MIG] timesheet_activity_report :Migration to 12.0#238
Reinhard-sheng wants to merge 4 commits intoElico-Corp:12.0from
Reinhard-sheng:12.0-mig-timesheet_activity_report

Conversation

@Reinhard-sheng
Copy link

@elicoidal @seb-elico
@Elico-Corp/odoo-reviewers

@Reinhard-sheng Reinhard-sheng changed the title [12.0][[BR001548]][MIG] migrate timesheet_activity_report to 12.0 [12.0][[BR001548]][MIG] timesheet_activity_report :Migration to 12.0 Mar 26, 2019
Copy link
Contributor

@elicoidal elicoidal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some details. LGTM

Credits
=======

Images
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

remove

* Reinhard Sheng <reinhard.sheng@elico-corp.com>


This module is maintained by Elico Corporation.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing part of the footer it seems

# License LGPL-3.0 or later (http://www.gnu.org/licenses/lgpl.html).
{
'name': 'Timesheet Activities Report',
'version': '12.0.1.1.0',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
'version': '12.0.1.1.0',
'version': '12.0.1.0.0',

Timesheet Activities Report.
"""
tools.drop_view_if_exists(cr, 'timesheet_activity_report')
cr.execute("""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@seb-elico probably requires that you have a deep look at current model structure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants

Comments