Skip to content

Add button colors to UiStyle#38

Merged
Ellpeck merged 23 commits intoEllpeck:mainfrom
Monniasza:main
Sep 11, 2025
Merged

Add button colors to UiStyle#38
Ellpeck merged 23 commits intoEllpeck:mainfrom
Monniasza:main

Conversation

@Monniasza
Copy link
Copy Markdown
Contributor

This PR adds configurable button colors by UiStyle, with the variable ButtonColor

@Monniasza
Copy link
Copy Markdown
Contributor Author

I forgot to add colors for checkboxes and radios too.

Copy link
Copy Markdown
Owner

@Ellpeck Ellpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks so much for this PR!

Unfortunately, it looks like there are also a bunch of other, unrelated files/changes included. Please resolve these before I can merge this :)

Feel free to also add default color properties for radio buttons and checkboxes, as you suggested!

@Monniasza
Copy link
Copy Markdown
Contributor Author

I've thought to add manually configurable colors to radio buttons. I'll add the full set of background colors too to every element.

@Monniasza
Copy link
Copy Markdown
Contributor Author

Added colors as promised in

@Monniasza
Copy link
Copy Markdown
Contributor Author

Maybe you would just copy the .gitignore from me @ https://github.com/Monniasza/TranSimCS/blob/master/.gitignore

Copy link
Copy Markdown
Contributor Author

@Monniasza Monniasza left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Requested changes done. Feel free to request more or accept them as they are.

@Ellpeck
Copy link
Copy Markdown
Owner

Ellpeck commented Sep 9, 2025

Hi, thanks for these changes! You still haven't untracked the .vs folder after adding it to the gitignore, so please do that :)

@Monniasza
Copy link
Copy Markdown
Contributor Author

Untracked in d36c860

@Ellpeck
Copy link
Copy Markdown
Owner

Ellpeck commented Sep 9, 2025

Your gitignore is correct, and was correct the first time. You need to untrack the files that were already committed before using git.

Copy link
Copy Markdown
Owner

@Ellpeck Ellpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some additional, small notes (only the first of which is really all that relevant!) Thanks :)

@Monniasza
Copy link
Copy Markdown
Contributor Author

@Ellpeck Are you willing to merge this PR right now?

@Ellpeck
Copy link
Copy Markdown
Owner

Ellpeck commented Sep 10, 2025

Hi! You haven't done some of the things I requested yet. You still have the .vs folder tracked, and there's still changes to the UI demo that I don't think should be on main.

@Monniasza
Copy link
Copy Markdown
Contributor Author

The Git implementation of the Visual Studio 2022 doesn't respect the .gitignore file. How could I fix it?

@Monniasza
Copy link
Copy Markdown
Contributor Author

As an addition, should I make all untextured UI textures white and set different default colors instead of using colored textures? I've now removed colors from the demo as you have requested.

@Monniasza
Copy link
Copy Markdown
Contributor Author

Fianlly deleted gitignored files, by using git rm -r --cached . and git add .. https://stackoverflow.com/a/67828150

Monniasza added a commit to Monniasza/TranSimCS that referenced this pull request Sep 11, 2025
Copy link
Copy Markdown
Owner

@Ellpeck Ellpeck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! All the stuff I commented on now looks good, thanks :)

For some reason, you now added a second version of the submodules from the ThirdParty directory into the root folder though? Why did you do that?

@Ellpeck Ellpeck merged commit 513e256 into Ellpeck:main Sep 11, 2025
4 of 5 checks passed
@Ellpeck
Copy link
Copy Markdown
Owner

Ellpeck commented Sep 11, 2025

Thank you so much! :)

@Monniasza
Copy link
Copy Markdown
Contributor Author

@Ellpeck When are you going to release a new version of this library, now with these enhancements?

@Ellpeck
Copy link
Copy Markdown
Owner

Ellpeck commented Sep 12, 2025

Releases are pretty infrequent, so I recommend using the prereleases :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants