Conversation
|
I forgot to add colors for checkboxes and radios too. |
Ellpeck
left a comment
There was a problem hiding this comment.
Hi, thanks so much for this PR!
Unfortunately, it looks like there are also a bunch of other, unrelated files/changes included. Please resolve these before I can merge this :)
Feel free to also add default color properties for radio buttons and checkboxes, as you suggested!
|
I've thought to add manually configurable colors to radio buttons. I'll add the full set of background colors too to every element. |
|
Maybe you would just copy the .gitignore from me @ https://github.com/Monniasza/TranSimCS/blob/master/.gitignore |
Monniasza
left a comment
There was a problem hiding this comment.
Requested changes done. Feel free to request more or accept them as they are.
|
Hi, thanks for these changes! You still haven't untracked the |
|
Untracked in d36c860 |
|
Your gitignore is correct, and was correct the first time. You need to untrack the files that were already committed before using git. |
Ellpeck
left a comment
There was a problem hiding this comment.
Some additional, small notes (only the first of which is really all that relevant!) Thanks :)
|
@Ellpeck Are you willing to merge this PR right now? |
|
Hi! You haven't done some of the things I requested yet. You still have the |
|
The Git implementation of the Visual Studio 2022 doesn't respect the .gitignore file. How could I fix it? |
|
As an addition, should I make all untextured UI textures white and set different default colors instead of using colored textures? I've now removed colors from the demo as you have requested. |
|
Fianlly deleted gitignored files, by using |
Ellpeck
left a comment
There was a problem hiding this comment.
Hi! All the stuff I commented on now looks good, thanks :)
For some reason, you now added a second version of the submodules from the ThirdParty directory into the root folder though? Why did you do that?
|
Thank you so much! :) |
|
@Ellpeck When are you going to release a new version of this library, now with these enhancements? |
|
Releases are pretty infrequent, so I recommend using the prereleases :) |
This PR adds configurable button colors by
UiStyle, with the variableButtonColor