Fix grouping and reduce RAM usage #1414
Open
shubhra-agrawal wants to merge 4 commits intoElucidataInc:developfrom
Open
Fix grouping and reduce RAM usage #1414shubhra-agrawal wants to merge 4 commits intoElucidataInc:developfrom
shubhra-agrawal wants to merge 4 commits intoElucidataInc:developfrom
Conversation
Made minor correction to array bounds check in peakAreaTop correction
Shrink m/z and intensity arrays to reduce RAM demand
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Copied from an email received from @AndrewRosko:
I have indeed found a small bug (2 missing lines) in the EIC pulling code that causes incorrect grouping of peaks, especially when searching by retention time as well as m/z.
The only other change I have made so far is another 2-line change in the mzSample file loader that trims some zeros off the Scan arrays, to cut the RAM usage by ~50%. On our system, despite still loading the entirety of the intensity data into memory, this makes a big difference in file load time.