-
Notifications
You must be signed in to change notification settings - Fork 4
Create database with external volume #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
73eec7b
to
f4dc0c2
Compare
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 28/48 (58.3%) |
rampage644
reviewed
Jul 15, 2025
rampage644
reviewed
Jul 15, 2025
rampage644
reviewed
Jul 15, 2025
rampage644
reviewed
Jul 15, 2025
rampage644
reviewed
Jul 15, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall lgtm, could we experiment with better error handling?
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 61/86 (70.9%) |
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 36/45 (80.0%) |
rampage644
approved these changes
Jul 15, 2025
Vedin
approved these changes
Jul 15, 2025
SQL Logic Tests Results ❌Coverage by SLT File
Overall: 99/150 (66.0%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CREATE DATABASE db_test external_volume = 'test_volume'
DROP DATABASE
comments from (commit was removed during rebase) Support drop database #1304SHOW DATABASES
to supportSHOW DATABASES STARTS WITH 'db_test'
Closes #510
Based on #Embucket/datafusion-sqlparser-rs#14
This PR allows to move to
CREATE DATABASE
sql instead of internal API call. After migration it is possible to remove job which checks created catalogs every 10 seconds.