Skip to content

Conversation

osipovartem
Copy link
Contributor

@osipovartem osipovartem commented Jul 15, 2025

  • added support for CREATE DATABASE db_test external_volume = 'test_volume'
  • tested with all types of volumes, for s3 tables return unimplemeted error
  • Fixed DROP DATABASE comments from (commit was removed during rebase) Support drop database #1304
    • Fixed catalog type and metastore errors for database in use, added tests
    • added specific unimplemented enum which was mentioned in comments
  • Added missing filters for SHOW DATABASES to support SHOW DATABASES STARTS WITH 'db_test'

Closes #510
Based on #Embucket/datafusion-sqlparser-rs#14
This PR allows to move to CREATE DATABASE sql instead of internal API call. After migration it is possible to remove job which checks created catalogs every 10 seconds.

Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • create-table: 19/36 (52.8%)
  • drop-table: 3/5 (60.0%)
  • merge: 6/7 (85.7%)

Overall: 28/48 (58.3%)

Copy link
Contributor

@rampage644 rampage644 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall lgtm, could we experiment with better error handling?

Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • nvl: 1/1 (100.0%)
  • is-null: 4/4 (100.0%)
  • nullif: 1/1 (100.0%)
  • create-table: 19/36 (52.8%)
  • drop-table: 3/5 (60.0%)
  • merge: 6/7 (85.7%)
  • nvl2: 1/1 (100.0%)
  • case: 3/3 (100.0%)
  • decode: 0/2 (0.0%)
  • insert: 22/25 (88.0%)
  • ifnull: 1/1 (100.0%)

Overall: 61/86 (70.9%)

Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • merge: 6/7 (85.7%)
  • from: 2/2 (100.0%)
  • into: 0/1 (0.0%)
  • drop-table: 3/5 (60.0%)
  • select: 19/20 (95.0%)
  • where: 6/10 (60.0%)

Overall: 36/45 (80.0%)

Copy link
Contributor

SQL Logic Tests Results ❌

Coverage by SLT File

  • from: 2/2 (100.0%)
  • join: 3/11 (27.3%)
  • connect-by: 1/2 (50.0%)
  • pivot: 8/13 (61.5%)
  • qualify: 2/5 (40.0%)
  • merge: 6/7 (85.7%)
  • insert: 22/25 (88.0%)
  • join-lateral: 0/4 (0.0%)
  • values: 4/5 (80.0%)
  • group-by: 4/7 (57.1%)
  • unpivot: 0/4 (0.0%)
  • into: 0/1 (0.0%)
  • group-by-grouping-sets: 1/3 (33.3%)
  • top_n: 1/2 (50.0%)
  • with: 3/8 (37.5%)
  • order-by: 7/8 (87.5%)
  • having: 2/2 (100.0%)
  • select: 19/20 (95.0%)
  • limit: 5/6 (83.3%)
  • where: 6/10 (60.0%)
  • drop-table: 3/5 (60.0%)

Overall: 99/150 (66.0%)

@osipovartem osipovartem merged commit 3b39863 into main Jul 15, 2025
6 of 8 checks passed
@osipovartem osipovartem deleted the issues/510_create_database branch July 15, 2025 21:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Discussion CREATE DATABASE

3 participants