engine: Remove dedicated_executor experiment
#1762
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanCodedThis
requested review from
JanKaul,
Vedin,
YaroslavLitvinov,
andheroe,
osipovartem and
rampage644
|
✅ SLT Targeted Testing: No relevant SLT tests found for the changes in this PR. No testing required. |
osipovartem
reviewed
Sep 25, 2025
| }) | ||
| .await | ||
| .context(ex_error::JobSnafu)??; | ||
| let stream = tokio::task::spawn(async move { |
There was a problem hiding this comment.
why even call tokio::task::spawn(async move?
already async
There was a problem hiding this comment.
tokio::task::spawn should schedule it on one of the worker threads
Or are you talking about the scope/block itself being async? If so, I just removed the dedicated executor, and haven't changed anything else
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1760
DedicatedExecutorseems to not use memory pools)