Refactor policy network code and remove LSTM as default#393
Draft
riccardosavorgnan wants to merge 1 commit into3.0from
Draft
Refactor policy network code and remove LSTM as default#393riccardosavorgnan wants to merge 1 commit into3.0from
riccardosavorgnan wants to merge 1 commit into3.0from
Conversation
| return logits, value | ||
|
|
||
|
|
||
| class MultiDiscreteDriveLSTM(Policy): |
Collaborator
Author
There was a problem hiding this comment.
This is still WIP, it might contain incomplete method and serious bugs.
| assert_near(output_puffer, output_torch.numpy()) | ||
|
|
||
|
|
||
| def test_drive(batch_size=1, input_size=512, hidden_size=512): |
Collaborator
Author
There was a problem hiding this comment.
will re-introduce before final review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Still WIP: refactoring of the neural net code for the policy plus remove the LSTM as default (MLP policy is now default)