Closed
Conversation
Kotlin 2.3.0 introduced stricter type parameter bounds checking. The `ValueSourceParameters.None` type is no longer valid as a type parameter bound because it doesn't satisfy the `Any` constraint. Changes: - Define EmptyParameters interface extending ValueSourceParameters - Update all ValueSource implementations to use EmptyParameters instead of None - Add explicit Any? bound to PropertyUtils.orEmpty() function This fixes compilation errors related to type parameter bounds and projection restrictions in Kotlin 2.3.0. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Kotlin 2.3.0 requires type parameters to be subtypes of Any, and String? (nullable) is not a subtype of Any. Changed all ValueSource implementations to return non-nullable String instead, using the elvis operator to return empty string for null values. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
Kotlin 2.3.0 requires type parameters to be subtypes of Any. Added explicit Any bound to the orEmpty function's type parameter. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
📸 Snapshot Test243 unchanged
🛸 Powered by Emerge Tools |
runningcode
commented
Jan 7, 2026
| if (gitHub.isSupportedGitHubEvent()) { | ||
| gitHub.sha()?.let { sha = it } | ||
| return if (gitHub.isSupportedGitHubEvent()) { | ||
| gitHub.sha() ?: "" |
Contributor
Author
There was a problem hiding this comment.
At first, I couldn't figure out how to re-use the orEmpty() function here and have it compile in the integration test. I will give it another pass tomorrow or in another PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ValueSourceParameters.Nonewith customEmptyParametersinterfaceAny?bound toPropertyUtils.orEmpty()function