Adjust spacing in the Feed header#461
Merged
trevor-e merged 2 commits intoEmergeTools:mainfrom May 16, 2025
Merged
Conversation
… issues with 85% text size on specific devices
noahsmartin
approved these changes
May 16, 2025
trevor-e
requested changes
May 16, 2025
Collaborator
trevor-e
left a comment
trevor-e
left a comment
There was a problem hiding this comment.
Thanks for fixing! One small request then can merge.
ios/HackerNews/Feed/FeedScreen.swift
Outdated
| .containerShape(.rect(cornerRadius: 24, style: .continuous)) | ||
|
|
||
| HStack(spacing: 16) { | ||
| Spacer() |
Collaborator
There was a problem hiding this comment.
Can this be Spacer(minLength: 0)? Otherwise I think this will add default padding to the sides.
ios/HackerNews/Feed/FeedScreen.swift
Outdated
| } | ||
| .frame(maxWidth: .infinity) | ||
| } | ||
| Spacer() |
trevor-e
approved these changes
May 16, 2025
NicoHinderling
pushed a commit
that referenced
this pull request
May 28, 2025
This is to better accommodate weird spacing issues with 85% text size on specific devices. Before:  After: 
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to better accommodate weird spacing issues with 85% text size on specific devices.
Before:
After:
