Skip to content

Add more Sentry config #465

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
trevor-e merged 2 commits into from
May 16, 2025
+28 −0
Merged

Add more Sentry config #465

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
23ac33b
Add more Sentry config
trevor-e May 16, 2025
f49d9d1
Add xctest environment
trevor-e May 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 28 additions & 0 deletions ios/HackerNews/HNApp.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,7 @@ struct HackerNewsApp: App {
SentrySDK.start { options in
options.dsn =
"https://118cff4b239bd3e0ede8fd74aad9bf8f@o497846.ingest.sentry.io/4506027753668608"

options.configureUserFeedback = { config in
config.onSubmitSuccess = { data in
print("Feedback submitted successfully: \(data)")
Expand All @@ -35,9 +36,36 @@ struct HackerNewsApp: App {
print("Failed to submit feedback: \(error)")
}
}

options.enableAppHangTrackingV2 = true
options.sessionReplay.onErrorSampleRate = 1.0
options.sendDefaultPii = true

#if DEBUG
options.environment = "development"
options.sessionReplay.sessionSampleRate = 1.0
options.tracesSampleRate = 1
// options.debug = true
Copy link

@armcknight armcknight May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// options.debug = true
options.debug = true

Not sure if you meant to comment this for debug builds

Copy link
Collaborator Author

@trevor-e trevor-e May 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yea I left this commented out for now since it was way noisier than I thought it would be.

options.configureProfiling = {
$0.profileAppStarts = true
$0.lifecycle = .trace
$0.sessionSampleRate = 1.0
}
#else
options.environment = "production"
options.sessionReplay.sessionSampleRate = 0.1
options.tracesSampleRate = 0.1
options.debug = false
options.configureProfiling = {
$0.profileAppStarts = true
$0.lifecycle = .trace
$0.sessionSampleRate = 0.1
}
#endif

if NSClassFromString("XCTest") != nil {
options.environment = "xctest"
}
}
}

Expand Down
Loading