Multiple period days marked on one period button click#287
Open
dydyamotya wants to merge 1 commit intoEmmaTellblom:mainfrom
Open
Multiple period days marked on one period button click#287dydyamotya wants to merge 1 commit intoEmmaTellblom:mainfrom
dydyamotya wants to merge 1 commit intoEmmaTellblom:mainfrom
Conversation
Add new setting: user_defined_period_length If this parameters > 0, then pressing "Period" button will mark this day and following [average period] days as period days. If average can't be calculated the user provided value is used
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello!
The topic was discussed in discord first, here is the explanation from discord message:
I've added a new setting: user_defined_period_length
If this parameters > 0, then pressing "Period" button will mark this day and following [average period] days as period days. If average can't be calculated the user provided value is used.
I'm open to discussion. I've started with most simple algorithm I could imagine.
I've tried to figure out all the edge cases.