fix loading configurations in NeoVim #11
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch fixes loading configurations in NeoVim in cases when no extra LSP config parameters are provided. After loading Emmyrc configs they were merged with partial Emmyrcs loaded based on the LSP config in NeoVim. If LSP hasn't got configuration section configured you came into a situation with only Null object partial Emmyrc overwriting the local Emmyrc configuration. Let's ignore Null LSP configurations (i.e. unprovided ones) to prevent them from completely overwriting other configurations when loading NeoVim LSP configuration options.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch fixes loading configurations in NeoVim in cases when no extra
LSP config parameters are provided. After loading Emmyrc configs
they were merged with partial Emmyrcs loaded based on the LSP config
in NeoVim. If LSP hasn't got configuration section configured you came
into a situation with only Null object partial Emmyrc overwriting
the local Emmyrc configuration.
Let's ignore Null LSP configurations (i.e. unprovided ones) to prevent
them from completely overwriting other configurations when loading
NeoVim LSP configuration options.