Prevent TplRef
s from escaping into types of global variables
#710
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a global variable is not annotated, and there's an assignment to it in a generic function, there's a chance that references to generic parameters will end up in its type.
This commit fixes the situation by skipping a type from a particular assignment if it contains generic references.
This is a rather simplistic implementation. We could be smarter about it: it's possible to analyze generics that're referenced from a type and replace them with their bounds:
However, this will require saving bounds to a global context, and lazily replacing them later. I've decided to leave it as is for now.