-
Notifications
You must be signed in to change notification settings - Fork 53
emmylua_doc_cli: support include patterns #807
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @myzhan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds support for --include patterns to the emmylua_doc_cli tool, allowing users to specify which files to include in the documentation generation. It also renames the --ignore flag to --exclude for clarity, while maintaining backward compatibility by keeping --ignore as an alias. The changes are well-implemented across the command-line argument parsing, configuration loading, and file collection logic. My review focuses on improving code readability. I've suggested using more descriptive variable names in init.rs to make the code easier to understand and maintain.
| if let Some(p) = include_pattern { | ||
| include.extend(p); | ||
| } else { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability, consider using a more descriptive variable name than p. For example, patterns or include_patterns would make it clearer what the variable contains.
| if let Some(p) = include_pattern { | |
| include.extend(p); | |
| } else { | |
| if let Some(patterns) = include_pattern { | |
| include.extend(patterns); | |
| } else { |
| if let Some(p) = exclude_pattern { | ||
| log::info!("Adding excludes from \"--exclude(or --ignore)\": {:?}", p); | ||
| exclude.extend(p); | ||
| } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better readability and consistency, consider using a more descriptive variable name than p. For example, patterns or exclude_patterns would make the code's intent clearer.
| if let Some(p) = exclude_pattern { | |
| log::info!("Adding excludes from \"--exclude(or --ignore)\": {:?}", p); | |
| exclude.extend(p); | |
| } | |
| if let Some(patterns) = exclude_pattern { | |
| log::info!("Adding excludes from \"--exclude(or --ignore)\": {:?}", patterns); | |
| exclude.extend(patterns); | |
| } |
See: #806