Conversation
SorinC6
changed the base branch from
develop
to
chore/YW-172/staking-revamp-layout
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/yoroi-extension/app/UI/features/staking/module/StakingContextProvider.tsx
Outdated
Show resolved
Hide resolved
...yoroi-extension/app/UI/features/staking/useCases/DelegatedStakePoolInfo/UndelegateButton.tsx
Show resolved
Hide resolved
packages/yoroi-extension/app/UI/features/staking/module/StakingContextProvider.tsx
Show resolved
Hide resolved
...yoroi-extension/app/UI/features/staking/useCases/DelegatedStakePoolInfo/UndelegateButton.tsx
Show resolved
Hide resolved
packages/yoroi-extension/app/UI/features/staking/common/hooks/useStrings.ts
Show resolved
Hide resolved
...roi-extension/app/UI/features/staking/useCases/DelegatedStakePoolInfo/StakePoolDelegated.tsx
Outdated
Show resolved
Hide resolved
packages/yoroi-extension/app/UI/features/staking/useCases/LegacyDialogs/LegacyDialogs.tsx
Show resolved
Hide resolved
Base automatically changed from
chore/YW-172/staking-revamp-layout
to
develop
December 17, 2025 16:32
packages/yoroi-extension/app/UI/features/staking/useCases/RewardsSummary/WithdrawButton.tsx
Show resolved
Hide resolved
packages/yoroi-extension/app/UI/features/staking/useCases/RewardsSummary/RewardsSummaryCard.tsx
Show resolved
Hide resolved
| }); | ||
| } | ||
| : undefined | ||
| } |
There was a problem hiding this comment.
Bug: Duplicate dialog opening logic in withdrawRewards handler
The withdrawRewards prop has redundant ternary branches where both isParticipatingToGovernance === false and isParticipatingToGovernance === true && isStakeRegistered === true open the same GovernanceParticipateDialog. This duplicated logic suggests the conditional may not be implementing the intended business rules correctly, as the same action is performed regardless of governance participation status when stake is registered.
Nebyt
approved these changes
Dec 18, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
task:
Note
Introduces the new staking dashboard (context, UI, dialogs) with rewards summary, delegated pool card (undelegate/update), epoch progress, pool list, and an empty-wallet banner; updates routes, i18n, and dependencies.
StakingRootlayout combiningRewardsSummaryCard,StakePoolDelegated,EpochProgress,PoolList, andLegacyDialogs.WalletEmptyBanner(testnet faucet link or buy/sell flow).DelegatedStakePoolCard,UndelegateButton(opens Tx review), and wiring viaStakePoolDelegated.EpochProgress,EpochProgressWrapper,EpochProgressCard.RewardsSummaryCard/RewardHistoryGraph: open reward history dialog, improved loading/error handling; totals rendering; y-axis masking tweak.StakingState(wallet, delegation, flags); improved graph data lifecycle (waits for reward history, resets on wallet change); unit-of-account helper; utilities.StakingSubpagesunderROUTES.STAKING_REVAMP.ROOT.CardanoStakingPagewith pool transition support.scroll; safer avatar loading inWalletDelegationBanner.@yoroi/apito6.0.0with updated peer deps in lockfile.Written by Cursor Bugbot for commit 0476e01. This will update automatically on new commits. Configure here.