Skip to content

fix NFT page layout to prevent image size change #4484

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Nebyt merged 6 commits into from
Jan 13, 2026
+23 −7
Merged

fix NFT page layout to prevent image size change #4484

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
8304c16
fix NFT page layout to prevent image size change
yushih Jan 8, 2026
93e8756
Merge branch 'develop' into fix/YW-332/nft-detail-layout
Nebyt Jan 12, 2026
3bcc64b
made changes to fit an image into the box
Nebyt Jan 12, 2026
c9589bf
fix format
Nebyt Jan 12, 2026
faff1fd
Merge branch 'develop' into fix/YW-332/nft-detail-layout
Nebyt Jan 12, 2026
d8f8045
fit image only on Details page
Nebyt Jan 13, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/yoroi-extension/app/UI/features/nfts/common/components/NftCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ export default function NftCard({ ipfsUrl, name, onClick, nftPathId }: NftCardPr
id={`${nftPathId}-component-button`}
>
<Box sx={{ borderRadius: '4px', overflow: 'hidden', flex: '1 1 auto' }}>
<NftImage imageUrl={ipfsUrl} name={name} width="100%" height="100%" nftPathId={nftPathId} />
<NftImage imageUrl={ipfsUrl} name={name} width="100%" height="100%" nftPathId={nftPathId} fillBox={true} />
</Box>
<Box>
<Typography
Expand Down
8 changes: 6 additions & 2 deletions packages/yoroi-extension/app/UI/features/nfts/common/components/NftImage.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,22 +12,26 @@ interface NftImageProps {
maxWidth?: string;
maxHeight?: string;
contentHeight?: string;
contentWidth?: string;
nftPathId: string;
imageSx?: SxProps;
onClickHandler?: () => void;
cursor?: string;
fillBox?: boolean;
}

export default function NftImage({
imageUrl,
name,
contentHeight,
contentWidth,
nftPathId,
width = 'auto',
height = 'auto',
imageSx = {},
onClickHandler,
cursor = 'default',
fillBox = false,
}: NftImageProps) {
const [loading, setLoading] = useState(true);
const [error, setError] = useState(false);
Expand All @@ -50,7 +54,7 @@ export default function NftImage({

if (error || url === null)
return (
<SvgWrapper height={contentHeight ? contentHeight : '100%'} id={`${nftPathId}-image-component`}>
<SvgWrapper height={contentHeight ?? '100%'} width={contentWidth ?? '100%'} id={`${nftPathId}-image-component`}>
<DefaultNft />
</SvgWrapper>
);
Expand All @@ -63,7 +67,7 @@ export default function NftImage({
sx={{
width,
height,
objectFit: 'cover',
objectFit: fillBox ? 'cover' : 'contain',
display: 'inline-block',
cursor,
...imageSx,
Expand Down
20 changes: 16 additions & 4 deletions packages/yoroi-extension/app/UI/features/nfts/useCases/NftDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,25 @@ const nftPathId = 'nftDetails';
const ImageItem = ({ nftInfo, onClick }: { nftInfo: Nft | null; onClick: () => void }) => {
if (!nftInfo) return null;
return (
<Box sx={{ overflow: 'hidden', height: '100%' }}>
<Box
sx={{
overflow: 'hidden',
width: '100%',
maxWidth: '550px',
height: '550px',
display: 'flex',
alignItems: 'center',
justifyContent: 'center',
}}
>
<NftImage
imageSx={{ borderRadius: '8px' }}
imageUrl={nftInfo.image}
name={nftInfo.name || '-'}
width="100%"
height="100%"
maxWidth="550px"
maxHeight="550px"
contentHeight="550px"
nftPathId={nftPathId}
onClickHandler={onClick}
Expand Down Expand Up @@ -74,7 +86,7 @@ export default function NftDetails() {
}

return (
<>
<Box>
<Box sx={{ mb: '24px', width: '100%' }}>
<Link to={ROUTES.NFT_GALLERY.ROOT}>
<Button
Expand All @@ -88,7 +100,7 @@ export default function NftDetails() {
</Button>
</Link>
</Box>
<Grid container columns={10}>
<Grid container columns={10} alignItems="flex-start">
<Grid item xs={4}>
<ImageItem onClick={openModal} nftInfo={currentNft} />
</Grid>
Expand Down Expand Up @@ -141,6 +153,6 @@ export default function NftDetails() {
/>
</Box>
</Modal>
</>
</Box>
);
}
Loading