Conversation
Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 143.0.2 to 143.0.3. - [Commits](giggio/node-chromedriver@143.0.2...143.0.3) --- updated-dependencies: - dependency-name: chromedriver dependency-version: 143.0.3 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…/e2e-tests/chromedriver-143.0.3 Bump chromedriver from 143.0.2 to 143.0.3 in /packages/e2e-tests
Bumps [chromedriver](https://github.com/giggio/node-chromedriver) from 143.0.3 to 143.0.4. - [Commits](giggio/node-chromedriver@143.0.3...143.0.4) --- updated-dependencies: - dependency-name: chromedriver dependency-version: 143.0.4 dependency-type: direct:development update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com>
…/e2e-tests/chromedriver-143.0.4 Bump chromedriver from 143.0.3 to 143.0.4 in /packages/e2e-tests
chore: YW-440 Implement Cardano card popup
show failed status from the thaw schedule endpoint
…load fix second click on the Receive tab causing infinite load
New Crowdin updates
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
[Fix] NFT explorer url
| <svg xmlns="http://www.w3.org/2000/svg" width="14" height="14" viewBox="0 0 16 16" fill="none"> | ||
| <path | ||
| fill-rule="evenodd" | ||
| clip-rule="evenodd" |
There was a problem hiding this comment.
Inconsistent SVG attribute naming convention
Low Severity
The SVG path uses hyphenated attributes fill-rule and clip-rule (lines 275-276) while another SVG path in the same component uses camelCase fillRule and clipRule (lines 285-286). In React/JSX, SVG attributes should consistently use camelCase notation.
| }; | ||
|
|
||
| checkModalState(); | ||
| }, [data]); |
There was a problem hiding this comment.
Missing cleanup for async operations in useEffect
Medium Severity
The useEffect runs an async function that performs localStorage operations and potentially calls openModal, but lacks a cleanup function to handle component unmount. If the component unmounts or data changes while the async operation is in progress, it will continue executing and attempt to call openModal and update the module-level hasProcessedThisSession variable after unmount, potentially causing memory leaks and unexpected modal behavior.
[Bump] Nightly Version: 5.20.0.1
update portfolio package
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| const redeemableIndex = schedule.thaws.findIndex(thaw => thaw.status === 'redeemable' || thaw.status === 'failed'); | ||
| if (redeemableIndex >= 0) return redeemableIndex; | ||
| const upcomingIndex = schedule.thaws.findIndex(thaw => thaw.status === 'upcoming'); | ||
| const upcomingIndex = schedule.thaws.findIndex(thaw => thaw.status === 'upcoming' || thaw.status === 'failed'); |
There was a problem hiding this comment.
Redundant failed status check in getCurrentThawIndex
Low Severity
The || thaw.status === 'failed' condition in the second findIndex call is redundant. If any thaw has status 'failed', it would already be found by the first findIndex on line 161, and the function would return before reaching line 163. This dead code adds unnecessary complexity.
[Bump] Nightly Version: 5.20.0.2
|
/check |
6 participants
Milestone: https://github.com/Emurgo/yoroi-frontend/milestone/156?closed=1
Change Set:
Note
Introduces a new promotional modal and multiple UX/data fixes across portfolio, airdrop, NFTs, and governance flows.
CardanoCardDialog(remote-config gated) with new strings, URL constant, and modal wiring inWallet; persistsAPP_OPENED_COUNTvia LocalStorage APIfailedthaw status in UI and totals; refactors Midnight redemption togetRedemptionUtxosand updatesRedeemflow; raises funding amount; timeline now marks failed stepsportfolioPercentage; overhauls table sorting (numeric/character handling, symbol-first names), parsing fixes, and chart hook signature (useGetPortfolioTokenChart(tokenInfo, interval)); updates chips/price/total to handle missing data safelyfillBox, content width) and details layout; fixnetworkUrlresolutionChooseOtherDrepIdnow accepts ADA handles, resolves to DRep ID via external API, with new validation/errorschromedriverto 143.0.4Written by Cursor Bugbot for commit 23f5a99. This will update automatically on new commits. Configure here.