Merged
Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
| { | ||
| "name": "yoroi", | ||
| "version": "5.20.0", | ||
| "version": "5.20.0.1", |
There was a problem hiding this comment.
Version number mismatches release branch
High Severity
The version is being set to 5.20.0.1 but the PR description indicates this nightly build comes from branch release/5.21. This creates a semantic versioning mismatch where the version number doesn't correspond to the release branch. The version should be 5.21.x.x to match the release/5.21 branch it's targeting, preventing version conflicts and deployment confusion between the 5.20 and 5.21 release lines.
Additional Locations (1)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR was created automatically using GitHub Actions.
Updating the version after publishing the new nightly version from branch
release/5.21Note
Updates the extension's version for nightly release.
versionfrom5.20.0to5.20.0.1inpackages/yoroi-extension/package.jsonandpackage-lock.jsonWritten by Cursor Bugbot for commit 52f54e1. This will update automatically on new commits. Configure here.