Conversation
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
packages/yoroi-extension/app/UI/components/Banners/BannerVisibilityManager.tsx
Show resolved
Hide resolved
packages/yoroi-extension/app/UI/features/governace/useCases/GovernanceOptions/DRepOptions.tsx
Show resolved
Hide resolved
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Continuing fixes and some UI rework after #4501
Note
Medium Risk
Medium risk because it removes an entire governance status route/component and changes delegation/staking UI flows and banner logic, which could affect navigation and user prompts in key wallet actions.
Overview
Governance UI is consolidated to a single entry point. The
ROUTES.GOVERNANCE.OPTIONSpath andGovernanceStatusPage/GovernanceStatuscomponents are removed, and/governancenow rendersGovernanceOptionsPagedirectly (withNotAllowedInGovernancegating handled inside the page).Promotional and gating UI around rewards/governance is removed. The
Rewardsbanner type, queue logic, andRewardsBannercomponent are deleted, andDelegateButtonno longer blocks staking delegation behind a governance-required modal.Delegation UX is streamlined.
useGovernanceDelegationToYoroiDrepis renamed/simplified touseGovernanceDelegation(dropping the directdelegateToDrepAPI), option-card skeleton loading is reduced from 4 to 3 cards, and some governance option page navigation/back UI and strings are trimmed/cleaned up.Written by Cursor Bugbot for commit b857863. This will update automatically on new commits. Configure here.