Skip to content

Comments

chore: merge from develop to preview#4439

Merged
jorbuedo merged 5 commits intopreviewfrom
develop
Dec 16, 2025
Merged

chore: merge from develop to preview#4439
jorbuedo merged 5 commits intopreviewfrom
develop

Conversation

@jorbuedo
Copy link
Contributor

@jorbuedo jorbuedo commented Dec 16, 2025

Note

Use signed transaction bytes directly for submission, remove NIGHT redemption operation detection, and always pass CBOR to the review screen without dev gating.

  • Transaction signing/submission:
    • useOnConfirm.signTx: now returns signedTxBytes alongside signedTx and txId; txId computed from signed bytes.
    • useOnConfirm.submitTx: submits using signedTxBytes directly (avoids re-serialization via Transaction.toBytes()), converts to base64 for API.
  • Review screen:
    • ReviewTxScreen: remove useAuth and dev gating; always pass params.cbor to ReviewTx; minor import consolidation.
  • Operation classification/display:
    • getOperationTypeKey and operationDisplay: comment out NIGHT redemption detection logic; retain swap/smart contract checks.

Written by Cursor Bugbot for commit 251521b. This will update automatically on new commits. Configure here.

@jorbuedo jorbuedo merged commit 12bde09 into preview Dec 16, 2025
3 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant