Skip to content

Revert "refactor: Consolidate dbproxy and user models (#461)"#594

Merged
dmohns merged 0 commit intomainfrom
revert-461-consolidate-databaseproxy-user-tables
Mar 26, 2025
Merged

Revert "refactor: Consolidate dbproxy and user models (#461)"#594
dmohns merged 0 commit intomainfrom
revert-461-consolidate-databaseproxy-user-tables

Conversation

@dmohns
Copy link
Copy Markdown
Member

@dmohns dmohns commented Mar 26, 2025

This reverts commit 00d566a06bd9f57dbe624b579a1be28ff5c7fcab.

Brief summary of the change made

Closes: #592

Currently, the Agent login is broken. And I'm not so sure anymore there is even a way to fix it.

image

This is how the model used to work before your change. Essentially both User and Agent models live in Tenant space. Then a Pivot table (DatabaseProxy) is used to map both of them to the corresponding Tenants.

image

In the updated model, there is no way (no pivot table) to map Agents to Tenants 🙀 . The only way would be to also make every Agent a User. But I don't think we can do this.
Because

Both Agents and Users have the Authenticatable trait. I.e. Agents could then log in as Users, but we don't want that. (specifically because we don't have a fully working Role/Permissions model)
Both Agent and User tables maintain password fields. We would either have to keep them in sync or change the Auth governance. Both of which seem to introduce more complexity than they remove.

Are there any other side effects of this change that we should be aware of?

Describe how you tested your changes?

Pull Request checklist

Please confirm you have completed any of the necessary steps below.

  • Meaningful Pull Request title and description
  • Changes tested as described above
  • Added appropriate documentation for the change.
  • Created GitHub issues for any relevant followup/future enhancements if appropriate.

@dmohns dmohns requested a review from beesaferoot March 26, 2025 09:51
@dmohns dmohns merged this pull request into main Mar 26, 2025
12 checks passed
@dmohns dmohns deleted the revert-461-consolidate-databaseproxy-user-tables branch March 26, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Agent creation does not create a User in Central database

2 participants