Revert "refactor: Consolidate dbproxy and user models (#461)"#594
Merged
Revert "refactor: Consolidate dbproxy and user models (#461)"#594
Conversation
beesaferoot
approved these changes
Mar 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 00d566a06bd9f57dbe624b579a1be28ff5c7fcab.
Brief summary of the change made
Closes: #592
Currently, the Agent login is broken. And I'm not so sure anymore there is even a way to fix it.
This is how the model used to work before your change. Essentially both User and Agent models live in Tenant space. Then a Pivot table (DatabaseProxy) is used to map both of them to the corresponding Tenants.
In the updated model, there is no way (no pivot table) to map Agents to Tenants 🙀 . The only way would be to also make every Agent a User. But I don't think we can do this.
Because
Both Agents and Users have the
Authenticatabletrait. I.e. Agents could then log in as Users, but we don't want that. (specifically because we don't have a fully working Role/Permissions model)Both Agent and User tables maintain password fields. We would either have to keep them in sync or change the Auth governance. Both of which seem to introduce more complexity than they remove.
Are there any other side effects of this change that we should be aware of?
Describe how you tested your changes?
Pull Request checklist
Please confirm you have completed any of the necessary steps below.