Skip to content

Conversation

@dolevf
Copy link
Contributor

@dolevf dolevf commented Dec 1, 2025

Which category is this pull request?

  • A new feature/enhancement.
  • Fix an issue/feature-request.
  • An improvement to existing modules.
  • Other (Please mention below).

Where has this been tested?

  • Python Version
    • v3.x
    • v2.x
  • Operating System:
    • Linux (Please specify distro)
    • Windows
    • MacOS

Does this close any currently open issues?

#234

Does this add any new dependency?

No

Does this add any new command line switch/argument?

No

Any other comments you would like to make?

Logic to detect Fastly WAF Is baesd on the Fastyl's documented X-Served-By header
https://www.fastly.com/documentation/reference/http/http-headers/X-Served-By/

@sandrogauci
Copy link
Member

The regex could be tightened to match Fastly's specific naming convention:

  # Current (broad):
  r'^cache-[^\s]*'

  # More specific to Fastly's format:
  r'^cache-[a-z]{3}\d+-[A-Z]{3}'

This would reduce false positives from generic Varnish setups while still catching Fastly's distinctive cache server naming.

@sandrogauci sandrogauci merged commit 8ab3d0c into EnableSecurity:master Jan 19, 2026
@sandrogauci
Copy link
Member

thanks for that @dolevf

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants