docs: enhance faq#387
Conversation
Aevarkan
left a comment
There was a problem hiding this comment.
Would using a footnote perhaps be better formatting wise? More details in the review.
|
I imagine this could leave someone reading this who wanted to run a server on arm architecture quite stranded. This PR currently tells them that Docker emulation allows Endstone to run on arm, but it doesn't show how to run it on arm architecture. I believe it'd be a good idea to also include a tutorial, or a link to one, in addition to confirming that Endstone can run on arm architecture via Docker emulation. |
Co-authored-by: Aevarkan <141498060+Aevarkan@users.noreply.github.com>
That sounds great! I initially assumed that "people will just look it up anyways", but it makes sense how people who don't know about Docker and such won't be able to set it up. Do you think it's worth actually making a page for setting this up, or is a link to something "good enough"? |
Depends on how much effort you want to put in 😆 Personally, I'd go for a dedicated page in the Note that, to add a new page, you'll need to also edit the Lines 195 to 202 in 7a07a52 Of course, it's not me that has the final say on this. |
I'll get working on a draft for the tutorial. It'll include most of the essential parts. Thank you! |
|
If you want a bit of inspiration, here's a tutorial I once made. One of my good ones! The tone I use is quite different from most. There's also the existing Endstone tutorials, which I'm sure you've already had a look at. |
|
I've made my tutorial in Initially, it was going to be a full beginner's guide to Docker, but I decided against that and went with that instead, as it's better to have it like a "quick start" guide rather than a full one as it's way more practical. |
Aevarkan
left a comment
There was a problem hiding this comment.
Good idea!
I didn't see how well that section already fit. I've made a few suggestions in the review. 🙂
| ```shell | ||
| # Create a new server called "endstone-server" that emulates an `amd64` architecture CPU, and bind the host port | ||
| # `19132` to the same port in the container. | ||
| docker run --platform linux/amd64 -p 19132:19132 -d --name endstone-server endstone/endstone | ||
| ``` |
There was a problem hiding this comment.
Two things here:
1
I recommend explaining these Docker flags outside of the code block:
--platform linux/amd64-p 19132:19132-d--name endstone-server
I got confused myself, I thought -d --name endstone-server was a single flag before I looked it up while writing this.
2
The existing documentation has the docker run command in the Getting Started > Start your server page instead of the Getting Started > Installation page.
endstone/docs/getting-started/start-your-server.md
Lines 14 to 27 in 7a07a52
There was a problem hiding this comment.
1
How about something like this:
docker run \
--platform linux/amd64 \ # Emulate Linux + amd64 architecture
-p 19132:19132 \ # Bind port 19132 on the host to the same port in the container
-it \ # Makes the output like a real terminal, and keeps stdin so you can type commands in
-v ${PWD}:/home/endstone \ # Mounts the disposable container a volume, so data like worlds will persist after the container is deleted.
--name endstone-server \
endstone/endstone(I've also made the command more consistent with the one Endstone's run command uses)
I think that's better, and we can comment on each flag individually (we could also make the other examples have such comments since Docker flags can be confusing).
2
The existing documentation has the docker run command in the Getting Started > Start your server page instead of the Getting Started > Installation page.
It makes sense to put it in there, I should've checked before putting it in installation. I'll move the "running" the server part into there.
There was a problem hiding this comment.
Sounds good!
It's up to you whether or not you could even add those comments for the other examples. Personally, I like that idea.
Co-authored-by: Aevarkan <141498060+Aevarkan@users.noreply.github.com>
Aevarkan
left a comment
There was a problem hiding this comment.
Looks mostly good - just some styling that stands out to me.
It might seem a bit strange to mention macOS, as Endstone doesn't officially support the platform.
Personally, I believe it's a good addition though. You'll have to get feedback from others regarding that.
Co-authored-by: Aevarkan <141498060+Aevarkan@users.noreply.github.com>
Co-authored-by: Aevarkan <141498060+Aevarkan@users.noreply.github.com>
Co-authored-by: Aevarkan <141498060+Aevarkan@users.noreply.github.com>
Co-authored-by: Aevarkan <141498060+Aevarkan@users.noreply.github.com>
Emulation makes Endstone work on macOS while also making it work on ARM, and a big portion of the ARM user base is on Apple silicon (which runs macOS by default). I've also confirmed that it works on macOS through emulation too, so I think it's a valid addition |
Co-authored-by: Aevarkan <141498060+Aevarkan@users.noreply.github.com>
|
Hi both! Thank you for the contribution and the discussion above. These changes look all good to me! |
|
I can't believe this amount of praise was enough to make me feel really happy 😁 |
Fix a grammatical error and acknowledge the viability with Endstone and ARM architectures.
I've added a tip in the FAQ that emphasizes how Docker emulation can make Endstone work on ARM with good performance. As the popularity of ARM for servers rises, I think making Endstone sound more viable for ARM in places such as the FAQ is important for the project's growth.