Skip to content

Conversation

@alexdewar
Copy link
Collaborator

Description

I was planning on making a start on a coding style document for humans and robots (following discussion on #1057), but figured it probably made sense to reorganise the developer docs a bit first. Presently all developer documentation lives in docs/developer_guide.md, but it's now a fairly long document covering a number of different topics (toolchain installation, pre-commit, building docs etc.) which probably deserve their own "chapters" (in mdbook-speak). So this is what I've done.

I made some small corrections/tweaks to the developer docs while I was at it, but nothing substantial has changed.

I also made some other docs-related tweaks:

  • Small fix to justfile
  • Replace unicode apostrophes
  • Rename main documents in docs/ and subfolders to README.md so they can also be navigated directly from github.com
  • Link to API docs in TOC and add placeholder file in case the user isn't building them along with the book

Type of change

  • Bug fix (non-breaking change to fix an issue)
  • New feature (non-breaking change to add functionality)
  • Refactoring (non-breaking, non-functional change to improve maintainability)
  • Optimization (non-breaking change to speed up the code)
  • Breaking change (whatever its nature)
  • Documentation (improve or add documentation)

Key checklist

  • All tests pass: $ cargo test
  • The documentation builds and looks OK: $ cargo doc

Further checks

  • Code is commented, particularly in hard-to-understand areas
  • Tests added that prove fix is effective or that feature works

Copilot AI review requested due to automatic review settings January 9, 2026 12:29
@codecov
Copy link

codecov bot commented Jan 9, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.09%. Comparing base (4b130da) to head (673a81a).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1059   +/-   ##
=======================================
  Coverage   82.09%   82.09%           
=======================================
  Files          53       53           
  Lines        7310     7310           
  Branches     7310     7310           
=======================================
  Hits         6001     6001           
  Misses       1019     1019           
  Partials      290      290           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR reorganizes the developer documentation into separate chapters and makes various documentation improvements. The main developer guide has been split into three focused chapters covering setup, coding, and documentation development. Additionally, main documentation files have been renamed to README.md for improved navigation on GitHub, and unicode apostrophes have been replaced with standard ASCII apostrophes throughout.

  • Restructured developer guide from a single file into separate chapters
  • Renamed main documentation files to README.md for better GitHub browsing
  • Fixed unicode apostrophes to ASCII apostrophes in model documentation
  • Enhanced justfile coverage command to accept arguments

Reviewed changes

Copilot reviewed 13 out of 16 changed files in this pull request and generated no comments.

Show a summary per file
File Description
justfile Added argument passing capability to coverage command
docs/model/investment.md Replaced unicode apostrophes with ASCII apostrophes and updated links to README.md
docs/model/dispatch_optimisation.md Replaced unicode apostrophes with ASCII apostrophes
docs/model/README.md Renamed from model_description.md for better GitHub navigation
docs/file_formats/README.md New file introducing file formats section
docs/developer_guide/setup.md New chapter covering development environment setup
docs/developer_guide/docs.md New chapter covering documentation development
docs/developer_guide/coding.md New chapter covering building and developing MUSE2
docs/developer_guide/README.md New intro file for developer guide with link to API docs
docs/developer_guide.md Deleted - content split into separate chapter files
docs/api/muse2/README.md New placeholder file for API documentation
docs/SUMMARY.md Updated to reflect new file structure and chapter organization
docs/README.md Updated links to point to new README.md files
CONTRIBUTING.md Updated developer guide link
CITATION.cff Replaced unicode apostrophe with ASCII apostrophe

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@alexdewar alexdewar requested review from Aurashk and tsmbland January 9, 2026 12:32
Copy link
Collaborator

@tsmbland tsmbland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approve!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants