CheckStyle: Fix or suppress remaining violations

Fixing public name violations might cause incompatibility with dependents (e.g. CH extensions and plugins depending on CH). Therefore, ignoring the current violations and ensuring it does not get worse is a safe choice for now.

Author: Pieter12345

src/main/java/com/laytonsmith/PureUtilities/Common/Annotations/CheckOverrides.java

@@ -238,8 +238,8 @@ public String toString(Class<?> item) {
 								"are %d methods which override or implement a method in a super class/super interface"
 								+ " but don't use the @Override tag. Please tag these methods"))
 						.append(" with @Override to continue the build process.")
-						.append(StringUtils.nl)
-						.append(StringUtils.Join(stringMethodsInError, StringUtils.nl));
+						.append(StringUtils.NL)
+						.append(StringUtils.Join(stringMethodsInError, StringUtils.NL));
 				processingEnv.getMessager().printMessage(Diagnostic.Kind.ERROR, b.toString());
 			} else {
 				StreamUtils.GetSystemOut().println("No @Override annotations were found to be missing.");

src/main/java/com/laytonsmith/PureUtilities/Common/StringUtils.java

@@ -764,7 +764,14 @@ public static String PluralTemplateHelper(int count, String singularTemplate, St
 	 * This is the system newline string. For instance, on windows, this would likely be \r\n, and unix systems would
 	 * likely be \n.
 	 */
-	public static final String nl = System.getProperty("line.separator");
+	public static final String NL = System.getProperty("line.separator");
+
+	/**
+	 * @deprecated Use {@link #NL} instead.
+	 */
+	@SuppressWarnings("checkstyle:constantname") // Fixing this violation might break dependents.
+	@Deprecated // Deprecated on 14-06-2018 dd-mm-yyyy.
+	public static final String nl = NL;
 
 	/**
 	 * This returns the system newline string. For instance, on windows, this would likely return \r\n, and unix systems
@@ -773,7 +780,7 @@ public static String PluralTemplateHelper(int count, String singularTemplate, St
 	 * @return The system newline string.
 	 */
 	public static String nl() {
-		return nl;
+		return NL;
 	}
 
 	/**

src/main/java/com/laytonsmith/PureUtilities/VirtualFS/FileSystemLayer.java

@@ -63,6 +63,7 @@ protected FileSystemLayer(VirtualFile path, VirtualFileSystem fileSystem) {
 	 */
 	@Retention(RetentionPolicy.RUNTIME)
 	@Target(ElementType.TYPE)
+	@SuppressWarnings("checkstyle:typename") // Fixing this violation might break dependents.
 	public static @interface fslayer {
 
 		/**

src/main/java/com/laytonsmith/PureUtilities/rParser.java

@@ -9,6 +9,7 @@
  * written by Nossr50, with portions contributed by Reil.
  *
  */
+@SuppressWarnings("checkstyle:typename") // Fixing this violation might break dependents.
 public final class rParser {
 
 	private rParser() {

src/main/java/com/laytonsmith/abstraction/enums/MCBiomeType.java

@@ -18,6 +18,7 @@ public abstract class MCBiomeType<Concrete> extends DynamicEnum<MCBiomeType.MCVa
 	protected static Map<String, MCBiomeType> mappings;
 	protected static Map<MCVanillaBiomeType, MCBiomeType> vanilla;
 
+	@SuppressWarnings("checkstyle:staticvariablename") // Fixing this violation might break dependents.
 	public static MCBiomeType NULL = null;
 
 	public MCBiomeType(MCVanillaBiomeType mcVanillaBiomeType, Concrete concrete) {

src/main/java/com/laytonsmith/abstraction/enums/MCEntityType.java

@@ -19,6 +19,7 @@ public abstract class MCEntityType<Concrete> extends DynamicEnum<MCEntityType.MC
 	protected static Map<String, MCEntityType> mappings;
 	protected static Map<MCVanillaEntityType, MCEntityType> vanilla;
 
+	@SuppressWarnings("checkstyle:staticvariablename") // Fixing this violation might break dependents.
 	public static MCEntityType NULL = null;
 
 	protected Class<? extends MCEntity> wrapperClass;

src/main/java/com/laytonsmith/abstraction/enums/MCSound.java

@@ -18,6 +18,7 @@ public abstract class MCSound<Concrete> extends DynamicEnum<MCSound.MCVanillaSou
 	// To be filled by the implementer
 	protected static Map<String, MCSound> mappings;
 
+	@SuppressWarnings("checkstyle:staticvariablename") // Fixing this violation might break dependents.
 	public static MCSound NULL = null;
 
 	public MCSound(MCVanillaSound mcVanillaSound, Concrete concrete) {

src/main/java/com/laytonsmith/annotations/abstraction.java

@@ -13,6 +13,7 @@
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
+@SuppressWarnings("checkstyle:typename") // Fixing this violation might break dependents.
 public @interface abstraction {
 
 	Implementation.Type type();

src/main/java/com/laytonsmith/annotations/abstractionenum.java

@@ -14,6 +14,7 @@
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
+@SuppressWarnings("checkstyle:typename") // Fixing this violation might break dependents.
 public @interface abstractionenum {
 
 	/**

src/main/java/com/laytonsmith/annotations/api.java

@@ -17,6 +17,7 @@
  */
 @Retention(RetentionPolicy.RUNTIME)
 @Target(ElementType.TYPE)
+@SuppressWarnings("checkstyle:typename") // Fixing this violation might break dependents.
 public @interface api {
 
 	public enum Platforms {