Skip to content

added "hand", "offhand" and "pos1" to the pattern suggestion #2869

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Adrien5902 wants to merge 6 commits into
base: master
Choose a base branch
from
+20 −2
Open

added "hand", "offhand" and "pos1" to the pattern suggestion #2869

Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b913260
added "hand", "offhand" and "pos1" to the pattern suggestion
Adrien5902 Dec 30, 2025
2157820
"hand", "offhand" and "pos1" are suggested every time in pattern
Adrien5902 Dec 30, 2025
16f46ff
"hand" and "offhand" pattern suggestions are now player only (not con…
Adrien5902 Dec 30, 2025
37c130f
player specific suggestions are now suggested based on input start
Adrien5902 Dec 30, 2025
81c3448
uppercased the S of handSide
Adrien5902 Dec 30, 2025
9f5cf83
revert change to imports
Adrien5902 Dec 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 20 additions & 2 deletions ...t-core/src/main/java/com/sk89q/worldedit/extension/factory/parser/DefaultBlockParser.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,12 @@
import org.enginehub.linbus.stream.exception.NbtParseException;
import org.enginehub.linbus.tree.LinCompoundTag;

import java.util.ArrayList;
import java.util.List;
import java.util.HashMap;
import java.util.Locale;
import java.util.Map;
import java.util.stream.Stream;
import java.util.Locale;
Copy link
Member

@me4502 me4502 Jan 1, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks like these imports are still out of order- Locale shouldn't have moved; it's probably worth ensuring that it builds locally and making the fixes until it actually builds first


/**
* Parses block input strings.
Expand Down Expand Up @@ -206,7 +208,23 @@ private static Map<Property<?>, Object> parseProperties(BlockType type, String[]
public Stream<String> getSuggestions(String input, ParserContext context) {
final int idx = input.lastIndexOf('[');
if (idx < 0) {
return SuggestionHelper.getNamespacedRegistrySuggestions(BlockType.REGISTRY, input);
List<String> suggestions = new ArrayList<>();

if ("pos1".startsWith(input)) {
suggestions.add("pos1");
}

if (context.getActor() != null && context.getActor().isPlayer()) {
for (String handSide : List.of("hand", "offhand")) {
if (handSide.startsWith(input)) {
suggestions.add(handSide);
}
}
}

return Stream.concat(
suggestions.stream(),
SuggestionHelper.getNamespacedRegistrySuggestions(BlockType.REGISTRY, input));
}
String blockType = input.substring(0, idx);
BlockType type = BlockTypes.get(blockType.toLowerCase(Locale.ROOT));
Expand Down
Loading