Ensure schematics manager is initialised on reloads#2896
Merged
me4502 merged 1 commit intoversion/7.4.xfrom Jan 21, 2026
Merged
Ensure schematics manager is initialised on reloads#2896me4502 merged 1 commit intoversion/7.4.xfrom
me4502 merged 1 commit intoversion/7.4.xfrom
Conversation
worldedit-core/src/main/java/com/sk89q/worldedit/extension/platform/Capability.java
Show resolved
Hide resolved
octylFractal
approved these changes
Jan 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move the init point of the schematics manager to the reload configuration event, running
uninitbefore the actual init to make sure that it's adequately cleaned up.uninitis safe to run when not yet initialised, as it checks before cleaning anything up.This also ensures that fallback schematic systems are initialised late enough to obtain necessary data.
This should fix issues such as #2895 with filesystems that need to fallback, as well the fact that reloading does not apply schematic folder changes (albeit without an issue number as it's not been reported)