Skip to content

Test action with PAT (part 2) #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Test action with PAT (part 2) #341

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f905af0
Test action with PAT
EnricoMi Aug 8, 2022
9055897
Do not use check API
EnricoMi Aug 8, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/ci-cd.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,6 +167,7 @@ jobs:
id: test-results
uses: ./
with:
github_token: ${{ secrets.PAT }}
check_name: Test Results (Dockerfile)
junit_files: "artifacts/**/*.xml"
json_file: "tests.json"
Expand Down Expand Up @@ -300,7 +301,7 @@ jobs:
-v "/home/runner/work/publish-unit-test-result-action/publish-unit-test-result-action":"$GITHUB_WORKSPACE" \
enricomi/publish-unit-test-result-action:latest
env:
INPUT_GITHUB_TOKEN: ${{ github.token }}
INPUT_GITHUB_TOKEN: ${{ secrets.PAT }}
INPUT_CHECK_NAME: Test Results (Docker Image)
INPUT_JUNIT_FILES: "artifacts/**/*.xml"
INPUT_JSON_FILE: "tests.json"
Expand Down Expand Up @@ -426,6 +427,7 @@ jobs:
id: test-results
uses: ./composite
with:
github_token: ${{ secrets.PAT }}
check_name: Test Results (${{ matrix.os-label }} python ${{ matrix.python }})
junit_files: "artifacts${{ steps.os.outputs.path-sep }}**${{ steps.os.outputs.path-sep }}*.xml"
json_file: "tests.json"
Expand Down Expand Up @@ -476,6 +478,7 @@ jobs:
id: test-results
uses: ./composite
with:
github_token: ${{ secrets.PAT }}
check_name: Test Results (setup-python)
junit_files: "artifacts/**/*.xml"
json_file: "tests.json"
Expand Down Expand Up @@ -515,6 +518,7 @@ jobs:
id: test-results
uses: ./
with:
github_token: ${{ secrets.PAT }}
check_name: Test Results (Test Files)
fail_on: nothing
junit_files: "test-files/junit-xml/**/*.xml"
Expand Down Expand Up @@ -559,6 +563,7 @@ jobs:
id: test-results
uses: ./
with:
github_token: ${{ secrets.PAT }}
check_name: Test Results (Test File)
fail_on: nothing
junit_files: "test-files/pytest/junit.gloo.standalone.xml"
Expand Down
5 changes: 3 additions & 2 deletions python/publish/publisher.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,7 +298,7 @@ def publish_check(self,
# get stats from earlier commits
before_stats = None
before_check_run = None
if self._settings.compare_earlier:
if self._settings.compare_earlier and False:
before_commit_sha = self._settings.event.get('before')
logger.debug(f'comparing against before={before_commit_sha}')
before_check_run = self.get_check_run(before_commit_sha)
Expand All @@ -319,6 +319,7 @@ def publish_check(self,
summary_with_digest = get_long_summary_with_digest_md(stats_with_delta, stats)
split_annotations = [annotation.to_dict() for annotation in all_annotations]
split_annotations = [split_annotations[x:x+50] for x in range(0, len(split_annotations), 50)] or [[]]
split_annotations = []
for annotations in split_annotations:
output = dict(
title=title,
Expand Down Expand Up @@ -347,7 +348,7 @@ def publish_check(self,
stats=stats,
stats_with_delta=stats_with_delta if before_stats is not None else None,
annotations=all_annotations,
check_url=check_run.html_url
check_url=check_run.html_url if check_run else None
)
self.publish_json(data)

Expand Down