fix: use env var indirection for inputs (CMD_EXEC)#737
Open
nbuckwalt wants to merge 1 commit intoEnricoMi:masterfrom
Open
fix: use env var indirection for inputs (CMD_EXEC)#737nbuckwalt wants to merge 1 commit intoEnricoMi:masterfrom
nbuckwalt wants to merge 1 commit intoEnricoMi:masterfrom
Conversation
nbuckwalt
added a commit
to Contrast-Security-OSS/publish-unit-test-result-action
that referenced
this pull request
Mar 26, 2026
…ed inputs
Replace direct ${{ inputs.* }} interpolation in run: blocks with
env: indirection. Assign each input to a step-level env var and
reference $ENV_VAR in shell commands.
Files changed:
- docker/action.yml: docker_platform, docker_registry, docker_image, docker_tag
- misc/action/json-output/action.yml: inputs.json (heredoc → echo "$JSON")
- misc/action/find-workflows/action.yml: inputs.url, inputs.query
- misc/action/package-downloads/action.yml: inputs.url, inputs.repo, inputs.package
Based on SHA c950f6f (v2.23.0).
See upstream EnricoMi#737.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
nbuckwalt
added a commit
to Contrast-Security-OSS/publish-unit-test-result-action
that referenced
this pull request
Mar 26, 2026
…ed inputs
Replace direct ${{ inputs.* }} interpolation in run: blocks with
env: indirection. Assign each input to a step-level env var and
reference $ENV_VAR in shell commands.
Files changed:
- docker/action.yml: docker_platform, docker_registry, docker_image, docker_tag
- misc/action/json-output/action.yml: inputs.json (heredoc → echo "$JSON")
- misc/action/find-workflows/action.yml: inputs.url, inputs.query
- misc/action/package-downloads/action.yml: inputs.url, inputs.repo, inputs.package
Based on SHA c950f6f (v2.23.0).
See upstream EnricoMi#737.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Security Fix: CMD_EXEC via direct input interpolation
Summary
Multiple inputs are directly interpolated into `run:` shell commands across 4 action files, enabling shell injection.
Affected files and inputs
Fix
Map all inputs to `env:` variables at the step level and reference the env vars in the script. For `docker/action.yml`, the docker image reference is now constructed as `"$DOCKER_REGISTRY/$DOCKER_IMAGE:$DOCKER_TAG"` using quoted env vars.
References
🤖 Generated with Claude Code