feat: unit test and refactoring#73
Open
nakib103 wants to merge 1 commit intoEnsembl:feature/refactorfrom
Open
Conversation
mluypaert
suggested changes
Mar 19, 2026
Member
mluypaert
left a comment
There was a problem hiding this comment.
Please rebase this to merge into main, and resolve any merge conflicts arising so the PR can be merged upon approval and only need approving once (as the merge conflict resolutions can result in review needing to be repeated).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
NW-55
Unit test and CI
ensembl-variation-utilspackage.ensembl-variation-utilspackageThe nextflow bin were taking a lot responsibility of figuring out the file locations, talking with databases etc. These responsibility has been taken of and given to a separate python package called ensembl-varation-utils. It has 3 separate modules -
/nfsand externalftpdirectory and file structure and can discover files such as FASTA, GFF, VEP cache etc. and do file operations.VEP config generation
Instead of hardcoding everything to
generate_vep_config.pyscript now we accept a JSON config which can be fashioned for each run with greater degree of variability. Seeassets/examplefor an example of a json config.