TaskCTL to eirctl migration

[RichardSlater]

[XXXX-<Title> - Please use the Work Item number and Title as PR Name, not subtasks]

📲 What

Migration from taskctl to eirctl based upon eirctl migration guide.

🤔 Why

Usage of taskctl is deprecated within Ensono Digital.

🛠 How

Following steps in: https://github.com/Ensono/eirctl/blob/docs/migration/docs/migration.adoc

👀 Evidence

🕵️ How to test

Notes for QA

✅ Acceptance criteria Checklist

• Code peer reviewed?
• Documentation has been updated to reflect the changes?
• Passing all automated tests, including a successful deployment?
• Passing any exploratory testing?
• Rebased/merged with latest changes from development and re-tested?
• Meeting the Coding Standards?

[RichardSlater]

🔧 SonarScanner Java Detection Issue - Resolution Summary

Problem Overview

During the eirctl migration, the CI pipeline encountered a critical issue where dotnet-sonarscanner could not detect Java, despite Java being installed and available in the container:

Could not find 'java' executable in JAVA_HOME or PATH.
The SonarScanner did not complete successfully
Post-processing failed. Exit code: 1

Root Cause Analysis

The issue stemmed from environment variable propagation problems between PowerShell and child .NET processes in Docker containers:

1. Container Image Versions: Initial attempts used ensono/eir-dotnet:1.2.22 and ensono/eir-infrastructure:1.2.22
2. Environment Variable Inheritance: PowerShell environment variables ($env:JAVA_HOME, $env:PATH) don't reliably propagate to child processes spawned by .NET tools
3. SonarScanner CLI Subprocess: The dotnet-sonarscanner tool launches the SonarScanner CLI as a child process, which couldn't access the Java runtime

Resolution Path

✅ Final Solution (Commits: 649c20c, 1fff5d2)

Upgraded container versions + Explicit environment configuration

1. Container Upgrade:

   • Updated to ensono/eir-dotnet:1.2.26 (includes pre-installed Java 17)
   • Updated to ensono/eir-infrastructure:1.2.26

2. Explicit Environment Variable Configuration:

   $env:JAVA_HOME = "/usr/lib/jvm/java-17-openjdk-amd64";
   $env:PATH = "$env:JAVA_HOME/bin:$env:PATH";

   • Set before both Invoke-SonarScanner -start and -stop operations
   • Added diagnostic output showing JAVA_HOME and PATH values
   • Ensures .NET child processes have direct access to Java

❌ Attempted Solutions That Failed

1. Attempt 1 (Commit: ab1927b):

   • ❌ Installing Java on GitHub Actions runner
   • Failed because eirctl runs tests inside Docker container, which cannot access runner's filesystem

2. Attempt 2 (Commit: fab7fbf):

   • ❌ Mounting Java from runner into Docker container via volume mounting
   • Failed due to volume mounting complexity and environment variable expansion issues in eirctl

3. Attempt 3 (Commit: 29d4eca):

   • ❌ Installing Java inside Docker container using apt-get
   • Failed due to PowerShell/bash syntax conflicts when mixing &&, >, 2>&1 operators

4. Attempt 4 (Commit: d4b352f):

   • ❌ Wrapping apt-get in bash -c to fix syntax issues
   • Failed (reason: overtaken by container upgrade approach)

Key Learnings

1. Container Image Selection: Using container images with pre-installed Java (v1.2.26) is more reliable than runtime installation
2. Environment Variable Propagation: Explicit environment variable setting is necessary before each SonarScanner operation
3. PowerShell in Docker: Mixing bash and PowerShell syntax in Docker containers requires careful handling
4. JAVA_HOME Configuration: Must point to JDK directory (e.g., /usr/lib/jvm/java-17-openjdk-amd64), not the binary

Related Issues

• SonarSource/sonar-dotnet#8552 - dotnet sonarscanner JAVA_HOME detection
• nosinovacao/dotnet-sonar#33 - Java executable not found

Files Modified

• build/eirctl/tasks.yaml - Updated test task with explicit JAVA_HOME/PATH configuration
• build/eirctl/contexts.yaml - Updated container versions to 1.2.26
• .github/workflows/ci-simple-api.yml - Removed unnecessary Java setup steps
• .github/workflows/ci-cqrs.yml - Removed unnecessary Java setup steps

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud