Draft
Conversation
ArgumentList is now used for passing a collection of arguments around. It's better than `[AsRef<OsStr>]` because it can accept a lot of different argument specifications: - All `AsRef<OsStr>` types directly, without slices, - `[AsRef<OsStr>]` same as before, - `Vec<OsStr>`, - Tuples of `Into<ArgumentList>` (all of the above and self), which get chained, - Unit, i.e. empty tuples. Basically, this makes it very easy to call commands - instead of having to convert all types into the same type and pack them into a slice, one can simply list all parameters in a tuple and it will be converted into a slice using the shortest conversion route. Other changes: - Restructured xtask code into modules. - Moved distributables from typst-package into dist folder. - typst-package now only contains actual package sources (and manual). - Made manual build reproducible by specifying last change time as build time instead of using current system time. - Simplified code that handles configuration by using a trait that coalesces input types instead of previous macros. - Improved cross-platform support for strings in Configure. Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
- Use variables in ci.yaml Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
Signed-off-by: Tin Švagelj <tin.svagelj@live.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ArgumentList is now used for passing a collection of arguments around. It's better than
[AsRef<OsStr>]because it can accept a lot of different argument specifications:AsRef<OsStr>types directly, without slices,[AsRef<OsStr>]same as before,Vec<OsStr>,Into<ArgumentList>(all of the above and self), which get chained,Basically, this makes it very easy to call commands - instead of having to convert all types into the same type and pack them into a slice, one can simply list all parameters in a tuple and it will be converted into a slice using the shortest conversion route.
So calls that previously looked like:
, now look like:
That's a small example, there's cases where this visual noise has been significantly reduced as well as several intermediate variables removed.
Other changes: