ExtendSlice 2 #1319
Open
ExtendSlice 2 #1319
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wsmoses
reviewed
Aug 19, 2025
| // Create the new slice on the original tensor. | ||
| auto newSlice = rewriter.create<stablehlo::SliceOp>( | ||
| op.getLoc(), operand, new_starts, new_limits, new_strides); | ||
|
|
Member
There was a problem hiding this comment.
if new_lhs and new_rhs are 0 [even if multiple users], we can just use the sliced operand directly instead of the extend
jumerckx
force-pushed
the
jm/extendslice
branch
from
afa65fc to
545a89e
Compare
jumerckx
force-pushed
the
jm/extendslice
branch
from
545a89e to
21ce854
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #1238
Now includes a guard to only apply the rewrite if the SliceOp is the only user of the ExtendOp. (#1296)