Tessera pass draft #1441
Draft
Tessera pass draft #1441
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meAD/Enzyme-JaX into jac-tessera
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
EnzymeJAX Benchmarks
| Benchmark suite | Current: c4d10eb | Previous: 7f88655 | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.000004314978991169483 s |
0.000004144166014157235 s |
1.04 |
scatter_sum / JaXPipe / cpu / Primal |
0.000004397982999216765 s |
0.000004226277908310294 s |
1.04 |
scatter_sum / JaX / tpu / Primal |
0.0001386552981915 s |
0.0001389866188168 s |
1.00 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001493743569939 s |
0.0001376257929019 s |
1.09 |
This comment was automatically generated by workflow using github-action-benchmark.
wsmoses
reviewed
Oct 8, 2025
| PatternRewriter &rewriter) const override { | ||
| FunctionType fnType = funcOp.getFunctionType(); | ||
|
|
||
| if (fnType.getNumResults() > 1) |
wsmoses
reviewed
Oct 8, 2025
wsmoses
reviewed
Oct 8, 2025
| LogicalResult | ||
| matchAndRewrite(func::ReturnOp returnOp, | ||
| PatternRewriter &rewriter) const override { | ||
|
|
Member
There was a problem hiding this comment.
we should first check whether our parent op is a tessera defineop and only then do the replacement
wsmoses
reviewed
Oct 8, 2025
| matchAndRewrite(func::FuncOp funcOp, | ||
| PatternRewriter &rewriter) const override { | ||
| FunctionType fnType = funcOp.getFunctionType(); | ||
|
|
Member
There was a problem hiding this comment.
eventually we will want to do some check if funcOp.hasAttr("tessera.convert") then do this conversion, otherwise leave the funcop alone
wsmoses
reviewed
Oct 8, 2025
| matchAndRewrite(func::CallOp callOp, | ||
| PatternRewriter &rewriter) const override { | ||
|
|
||
| rewriter.replaceOpWithNewOp<tessera::CallOp>(callOp, callOp.getResultTypes(), |
Member
There was a problem hiding this comment.
we need to get the symbol we're calling into, and only if that symbol is a tessera.define do we do the call conversion
wsmoses
approved these changes
Oct 8, 2025
Member
wsmoses
left a comment
wsmoses
left a comment
There was a problem hiding this comment.
add some tests (and the checks) otherwise looks good!
jessicacotturone21
force-pushed
the
tessera_pass_draft
branch
from
e031649 to
838368d
Compare
jessicacotturone21
force-pushed
the
tessera_pass_draft
branch
from
acf9423 to
1c0187b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.