refactor: cleanup linalg/lapack lowering #1501
Draft
+682
−730
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
force-pushed
the
ap/cleanup_linalg_lapack_lowering
branch
from
47bb288 to
ffe67f2
Compare
avik-pal
force-pushed
the
ap/cleanup_linalg_lapack_lowering
branch
from
f7181f0 to
ff5d7fc
Compare
avik-pal
force-pushed
the
ap/cleanup_linalg_lapack_lowering
branch
from
ff5d7fc to
2065aae
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
EnzymeJAX Benchmarks
| Benchmark suite | Current: 2065aae | Previous: fd8e1c1 | Ratio |
|---|---|---|---|
scatter_sum / JaX / cpu / Primal |
0.0000044068062008591366 s |
0.000004408689998672344 s |
1.00 |
scatter_sum / JaXPipe / cpu / Primal |
0.000004318388301180675 s |
0.000004365386901190504 s |
0.99 |
scatter_sum / JaX / tpu / Primal |
0.0001538912215997 s |
0.0001303062093997 s |
1.18 |
scatter_sum / JaXPipe / tpu / Primal |
0.0001548538321978 s |
0.000130511138399 s |
1.19 |
This comment was automatically generated by workflow using github-action-benchmark.
avik-pal
force-pushed
the
ap/cleanup_linalg_lapack_lowering
branch
2 times, most recently
from
9b41169 to
75a34c4
Compare
avik-pal
force-pushed
the
ap/cleanup_linalg_lapack_lowering
branch
from
75a34c4 to
51e772c
Compare
avik-pal
force-pushed
the
ap/cleanup_linalg_lapack_lowering
branch
from
82cd86d to
302bd57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Somehow i managed to trigger a stackoverflow on reactant with this change