Skip to content

Conversation

@giordano
Copy link
Member

This seems to solve for me locally the error

[05:01:02] external/enzyme_ad/src/enzyme_ad/jax/Passes/AffineToStableHLORaising.cpp:19:10: error: module @enzyme_ad//src/enzyme_ad/jax:XLADerivatives does not depend on a module exporting 'mlir/Dialect/Affine/LoopUtils.h'
[05:01:02]    19 | #include "mlir/Dialect/Affine/LoopUtils.h"
[05:01:02]       |          ^
[05:01:02] 1 error generated.

As far as I understand, this is defined in https://github.com/llvm/llvm-project/blob/4e44bd027bf4e490380be770172994561616bd2d/utils/bazel/llvm-project-overlay/mlir/BUILD.bazel#L4210-L4239.

Ref: JuliaPackaging/Yggdrasil#10587 (comment)

This seems to solve for me locally the error
```
[05:01:02] external/enzyme_ad/src/enzyme_ad/jax/Passes/AffineToStableHLORaising.cpp:19:10: error: module @enzyme_ad//src/enzyme_ad/jax:XLADerivatives does not depend on a module exporting 'mlir/Dialect/Affine/LoopUtils.h'
[05:01:02]    19 | #include "mlir/Dialect/Affine/LoopUtils.h"
[05:01:02]       |          ^
[05:01:02] 1 error generated.
```
@giordano
Copy link
Member Author

giordano commented Feb 22, 2025

I have no idea why

  1. CI here (Linux and macOS) was happy
  2. CI in Reactant.jl (Linux and macOS) was happy
  3. doing a build in BinaryBuilder targeting Linux (but not macOS) platforms was happy
  4. I could reproduce on hydra (on Linux) the error reported at Reactant_jll v0.0.72 JuliaPackaging/Yggdrasil#10587 (comment) with build_local.jl (which is the same script used by CI in Reactant.jl), so outside of BinaryBuilder, but on a different target than the one failing inside BinaryBuilder (macOS there, Linux locally for me)

How literally anything works in Bazel will forever remain a mystery to me.

@giordano
Copy link
Member Author

Another example of missing dependency not caught by CI: d1ea997 😭

@wsmoses wsmoses merged commit 6ff1dc8 into EnzymeAD:main Feb 22, 2025
10 checks passed
@giordano giordano deleted the patch-1 branch February 22, 2025 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants