-
Notifications
You must be signed in to change notification settings - Fork 79
Add warnings #2415
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Add warnings #2415
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| module EnzymeDifferentiationInterfaceExt | ||
|
|
||
| function __init__() | ||
| @warn """You are using DifferentiationInterface!" | ||
| DifferentiationInterface introduces interstitial wrappers that may limit the scope of input programs and add overhead." | ||
| This can cause derivatives to be slower, or fail to differentiate with default settings when they work with Enzyme directly (e.g. Enzyme.gradient instead of DI.gradient)." | ||
| If you find issues, please report at https://github.com/EnzymeAD/Enzyme.jl/issues/new and try Enzyme directly in the interim.""" | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. In the spirit of lightening your load, wouldn't you want people to submit these issues to DI instead? |
||
| end | ||
|
|
||
| end # module | ||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,9 @@ | ||
|
|
||
| function __init__() | ||
| if VERSION >= v"1.11.0" | ||
| @warn """You are using Julia v1.11 or later!" | ||
| Julia 1.11 changes the default Array type to contain a triply-nested pointer, rather than a doubly nested pointer." | ||
| This may cause programs (primal but especially derivatives) to be slower, or fail to differentiate with default settings when they previously worked on 1.10." | ||
| If you find issues, please report at https://github.com/EnzymeAD/Enzyme.jl/issues/new and try Julia 1.10 in the interim.""" | ||
| end | ||
| end |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would remove "interstitial", I think most non native English speakers don't know the word. Also it isn't clear what you mean by "limit the scope"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah I just meant that programs need to be rewritten to be DI compatible (eg can’t have multiple active args, dupnoneed as arg etc). So then general programs that are supported by enzyme directly aren’t necessarily supported by DI (at least without a rewrite)