Skip to content

Conversation

@vchuravy
Copy link
Member

@vchuravy vchuravy commented Oct 14, 2025

In contrast to #2613 this only adds one job for now. I propose that we merge this so that we can have a canary when things are breaking (more).

@vchuravy vchuravy requested a review from giordano October 14, 2025 19:39
@codecov
Copy link

codecov bot commented Oct 14, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 75.14%. Comparing base (8a7874e) to head (eb0a6e0).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2671   +/-   ##
=======================================
  Coverage   75.14%   75.14%           
=======================================
  Files          57       57           
  Lines       17958    17958           
=======================================
  Hits        13495    13495           
  Misses       4463     4463           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@giordano
Copy link
Member

giordano commented Oct 14, 2025

we can have a canary when things are breaking (more).

Not easy to actively see when there are more breaking changes when tests are already failing, is it?

@vchuravy
Copy link
Member Author

Not easy to actively see when there are more breaking changes when tests are already failing, is it?

It's more to show that the 1.12 PRs I am making are making headway.

Copy link
Member

@giordano giordano left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I see 👍

@giordano giordano added github_actions Pull requests that update GitHub Actions code Julia v1.12 Related to compatibility with Julia v1.12 labels Oct 14, 2025
@vchuravy vchuravy merged commit d2ec552 into main Oct 15, 2025
29 of 31 checks passed
@vchuravy vchuravy deleted the vc/1.12_CI_min branch October 15, 2025 01:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

github_actions Pull requests that update GitHub Actions code Julia v1.12 Related to compatibility with Julia v1.12

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants