Default to post conversion to dynamic update slice #1496
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
giordano
reviewed
Jul 28, 2025
| @@ -691,7 +691,7 @@ const SUM_TO_CONV = Ref(false) | |||
| const AGGRESSIVE_SUM_TO_CONV = Ref(false) | |||
| const AGGRESSIVE_PROPAGATION = Ref(false) | |||
| const DUS_SLICE_SIMPLIFY = Ref(true) | |||
| const CONCATS_TO_DUS = Ref(false) | |||
| const CONCATS_TO_DUS = Ref(true) | |||
There was a problem hiding this comment.
[assuming we ofc nicely fix dus comm and other things, so can revert/change/etc things]
giordano
reviewed
Jul 28, 2025
Co-authored-by: Mosè Giordano <[email protected]>
jumerckx
approved these changes
Jul 29, 2025
There was a problem hiding this comment.
This looks good to me, though I'm not sure what this CI failure is https://github.com/EnzymeAD/Reactant.jl/actions/runs/16577306883/job/46884662450?pr=1496#logs
|
That's #1497. |
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.