-
Notifications
You must be signed in to change notification settings - Fork 33
feat: caching code in mapreduce style ops #1662
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
a57d94f to
9549a6e
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1662 +/- ##
==========================================
+ Coverage 68.82% 68.86% +0.04%
==========================================
Files 103 103
Lines 11596 11599 +3
==========================================
+ Hits 7981 7988 +7
+ Misses 3615 3611 -4 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
| end | ||
|
|
||
| (fn::BroadcastIterator)(args...) = Reactant.call_with_reactant(fn.f, (args...,)) | ||
| (fn::BroadcastIterator)(args...) = fn.f((args...,)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Trying to understand what this is doing. Why isn't call_with_reactant required anymore, or why was it required before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is meant to be only used instead broadcast which with force the call_via_reactant in elem_apply (it should have not been added in the first place)
|
So this looks reasonable to me (though not sure if the CI failure is related to this pr?) One major caveat is that the caching mechanism for function f(X, y)
push!(X, y)
end
# X::Vector{TracedRArray}
# y::TracedRArraybecause in this case tracing through Billy mentioned the need for an analysis that tells whether such a mutation occurs. I've looked into this a little bit but haven't yet found a good way to do this. |
|
Ah I see, in that case, let's hold off on the caching part. I will separate out the non-caching fixes in a separate PR |
c038c6c to
084b6d3
Compare
* feat: better support for Base.Generators * feat: use traced_call when unrolling iterators and generators * fix: closure with call working * fix: try removing nospecialize * fix: use a looped version of any to avoid inference issues * fix: dont overlay inside compiler call
084b6d3 to
8a5ef1d
Compare
No description provided.