symm op #1777
Open
symm op #1777
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
avik-pal
reviewed
Oct 19, 2025
| location, | ||
| ), | ||
| ) | ||
| return res |
There was a problem hiding this comment.
construct a TracedRArray before returning (see the dot_general case below)
avik-pal
reviewed
Oct 19, 2025
| C.mlir_data, | ||
| alpha.mlir_data, | ||
| beta.mlir_data; | ||
| output=mlir_type(TracedRArray{eltype(C),length(ressize)}, ressize), |
There was a problem hiding this comment.
eltype(c) make this into unwrapped_eltype
avik-pal
reviewed
Oct 20, 2025
| β::Number=true, | ||
| ) | ||
| # Promote to traced arrays | ||
| A = call_with_reactant(Reactant.promote_to, TracedRArray, A.data) |
There was a problem hiding this comment.
Suggested change
| A = call_with_reactant(Reactant.promote_to, TracedRArray, A.data) | |
| A = call_with_reactant(Reactant.promote_to, TracedRArray, parent(A)) |
avik-pal
reviewed
Oct 20, 2025
Comment on lines
+277
to
+279
| @nospecialize(C::TracedRArray{T,2} where {T}), | ||
| @nospecialize(A::Symmetric), | ||
| @nospecialize(B::AbstractMatrix), |
There was a problem hiding this comment.
Also add the version where B is Symmetric
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.