Skip to content

Add degree-based trigonometric and inverse-trigonometric wrappers for TracedRNumber #1785

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Add degree-based trigonometric and inverse-trigonometric wrappers for TracedRNumber #1785

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
25 changes: 25 additions & 0 deletions src/TracedRNumber.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -505,6 +505,31 @@ for (jlop, hloop) in (
@eval $(jlop)(@nospecialize(lhs::TracedRNumber)) = @opcall $(hloop)(lhs)
end

# Degree-based trigonometric wrappers for TracedRNumber:

# These convert to radians internally so Reactant/XLA can lower to StableHLO-supported radian trigonometric operations.

# --- Basic trigonometric functions ---
Base.sind(x::TracedRNumber) = sin(deg2rad(x))
Base.cosd(x::TracedRNumber) = cos(deg2rad(x))
Base.tand(x::TracedRNumber) = tan(deg2rad(x))
Base.cscd(x::TracedRNumber) = 1 / sind(x)
Base.secd(x::TracedRNumber) = 1 / cosd(x)
Base.cotd(x::TracedRNumber) = 1 / tand(x)

# --- Inverse trigonometric functions ---
Base.asind(x::TracedRNumber) = rad2deg(asin(x))
Base.acosd(x::TracedRNumber) = rad2deg(acos(x))
Base.atand(x::TracedRNumber) = rad2deg(atan(x))

# Two-argument atan in degrees
Base.atand(y::TracedRNumber, x::TracedRNumber) = rad2deg(atan(y, x))

# Derived inverse functions using trigonometric identities
Base.acscd(x::TracedRNumber) = rad2deg(asin(1 / x))
Base.asecd(x::TracedRNumber) = rad2deg(acos(1 / x))
Base.acotd(x::TracedRNumber) = rad2deg(atan(1 / x))

for (jlop, hloop) in (
(:(Base.sin), :sine),
(:(Base.cos), :cosine),
Expand Down
Loading